Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Neo4j service to release workflow #3

Merged

Conversation

alexthomas93
Copy link
Collaborator

@alexthomas93 alexthomas93 commented Nov 5, 2024

This PR adds a Neo4j service to the _release.yml workflow and removes unneeded environment variables from the integration tests step.

@alexthomas93 alexthomas93 requested a review from efriis November 5, 2024 11:26
@alexthomas93 alexthomas93 self-assigned this Nov 5, 2024
@alexthomas93 alexthomas93 changed the title Adds a Neo4j service to release workflow Adds a Neo4j service to release workflow + updates imports Nov 5, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure you want to remove the top-level namespace? that's what other packages do

if you're worried about import time, you could use a __getattr__ function instead that dynamically looks up objects and imports them when requested

@efriis
Copy link
Member

efriis commented Nov 6, 2024

otherwise lgtm!

@alexthomas93 alexthomas93 force-pushed the bugfix/release-workflow branch from 1560da1 to d24b334 Compare November 6, 2024 10:03
@alexthomas93 alexthomas93 changed the title Adds a Neo4j service to release workflow + updates imports Adds a Neo4j service to release workflow Nov 6, 2024
@alexthomas93
Copy link
Collaborator Author

you sure you want to remove the top-level namespace? that's what other packages do

if you're worried about import time, you could use a __getattr__ function instead that dynamically looks up objects and imports them when requested

Yeah, I think I was prematurely trying to optimise the imports. I've reverted things to how they were for now on the imports side. Will merge

@alexthomas93 alexthomas93 merged commit f58b60b into langchain-ai:main Nov 6, 2024
16 checks passed
@alexthomas93 alexthomas93 deleted the bugfix/release-workflow branch November 6, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants