Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing lucene special char to remove_lucene_chars #36

Merged
merged 5 commits into from
Jan 11, 2025

Conversation

alexthomas93
Copy link
Collaborator

Description

Adds the / character to the list of characters to be escaped before sending a query to Apache Lucene.

See list of special characters

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Project configuration change

Complexity

Low

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests

Checklist

  • Unit tests updated
  • Integration tests updated
  • CHANGELOG.md updated

@alexthomas93
Copy link
Collaborator Author

@CodiumAI-Agent /update_changelog

@CodiumAI-Agent
Copy link

Changelog updates: 🔄

[2025-01-10][https://github.com//pull/36]

Fixed

  • Added missing Lucene special character / to the list of characters escaped in remove_lucene_chars.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

@alexthomas93 alexthomas93 linked an issue Jan 10, 2025 that may be closed by this pull request
@alexthomas93 alexthomas93 merged commit c1e5ae4 into langchain-ai:main Jan 11, 2025
8 checks passed
@alexthomas93 alexthomas93 deleted the fix/lucene-escaping branch January 11, 2025 21:08
@CodiumAI-Agent
Copy link

Changelog updates: 🔄

[2025-01-11]*

Fixed

  • Added missing Lucene special character '/' to the list of characters escaped in remove_lucene_chars.

to commit the new content to the CHANGELOG.md file, please type:
'/update_changelog --pr_update_changelog.push_changelog_changes=true'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lucene keyword search sanitization
3 participants