Include variable scope clause in deprecated Cypher query #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtai
force-pushed
the
update-deprecated-cypher-with-subqueries
branch
from
86bee58 to
502485b
Compare
willtai
force-pushed
the
update-deprecated-cypher-with-subqueries
branch
from
502485b to
2a01b8f
Compare
stellasia
reviewed
Nov 18, 2024
| @@ -93,7 +93,7 @@ def _get_search_index_query( | |||
| "YIELD node, score " | |||
| ), | |||
| SearchType.HYBRID: ( | |||
| "CALL { " | |||
| "CALL () { " | |||
There was a problem hiding this comment.
Are we supporting only neo4j >= 5.23 ?
There was a problem hiding this comment.
Good point, I should include the old queries for older versions
There was a problem hiding this comment.
I created another ticket to add support for Neo4j < 5.23 across the package. Feel free to add in support here but ideally we should think about exactly which versions we want to support and come up with a strategy that works across the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous Cypher query would include a warning that the Cypher query will be deprecated. This PR update the query to have a variable scope clause. See https://neo4j.com/docs/cypher-manual/current/subqueries/call-subquery/#variable-scope-clause
This PR also adds a unit test and was manually tested.