vectorstore: Add support to filter by IS NULL and IS NOT NULL criteria #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinGotelli
commented
May 4, 2024
MartinGotelli
changed the title
eyurtsev
reviewed
May 15, 2024
eyurtsev
approved these changes
May 16, 2024
This was referenced May 17, 2024
eyurtsev
pushed a commit
that referenced
this pull request
May 18, 2024
So... yeah I f***ed up. But this is the fix. The $exists was working as the $null, but the rename implies also changing how the bool value is interpreted: $exists: True (there is a tag, I don't care the value) $exists: False (no tag in there) ref: #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add support to filter by IS NULL criteria in the metadata
Issue: N/A
Dependencies: N/A
Twitter handle: @martinferenaz
This PR fixes the problem when you want to search if a tag has a value (exists) in the metadata. To check that you need to compare with the "IS NULL" method and the "$eq" operator only checks that the tag exists and has a null value assigned.
In addition, a test for the $nin condition was added and a bug arrised, the bug was resolved adding a not condition after the in_