feat: add hnsw index functionality to PGVector #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
eyurtsev
reviewed
Jul 12, 2024
|
|
||
| return create_index_query | ||
|
|
||
| def create_hnsw_index( |
There was a problem hiding this comment.
Is there anyway to move this to a classmethod, so we can create the ahead of time.
I want to create a control plane -- that allows managing the indexes without having to actually instantiate an index.
class IndexManager:
def list_indexes(**kwargs) -> List[Dict]:
def get_index(id) -> VectorStore:
pass
def create_index(**kwargs) -> str:
passThere was a problem hiding this comment.
Hi @eyurtsev thanks for the feedback. Honestly I'm not too sure how to do this as this is my first PR to the project. Feel free to commandeer the PR (or merge it and create a new one if it makes more sense)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: langchain-ai/langchain#23853
description: unlike the PGEmbedding class (which uses "pg_embedding" extension) , the PGVector class (which uses "pg_vector" extension) currently doesn't support HNSW index. Since the pg_embedding project is deprecated since 2023 https://github.com/neondatabase/pg_embedding and it is encouraged to move to pg_vector, I added the HNSW support in the PGVector class