fix(vectorstores.py): fetch embedding for the near_vector method
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the near_vector method accepts a parameter called "near_vector", for which the method will perform vector search to get the nearest vector(s). We should get the vector using the embedding object, just as we did in the `hybrid` search method, 4 lines above it.
|
@hkhairy thanks for your contribution! Unfortunately, the team decided to remove calls to near_vector (see #141) in favor of using hybrid search to do the searches. This is a more flexible option since users can configure how much vector vs keyword search they want by configuring the So, I will close this PR. Looking forward to collaborating with you in the future! |
|
@hsm207 Looking forward to collaborating with you as well 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_perform_searchisn't passed the embedding of the query #132The
near_vectormethod accepts a parameter called "near_vector", for which the method will perform vector search to get the nearest vector(s). We should get the vector using the embedding object, just as we did in thehybridsearch method, 4 lines above it.