-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a clear() method to VectorStoreRetrieverMemory with FAISS vector store #10169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: vector store
Related to vector store module
🤖:improvement
Medium size change to existing code to handle new use-cases
labels
Sep 4, 2023
uray-lu
changed the title
Add a clear() method to VectorStoreRetrieverMemory
Add a clear() method to VectorStoreRetrieverMemory with FAISS vector store
Sep 5, 2023
Hi, I was also running to this issue. What happened to this PR next? Why was it closed? Thanks for your help. |
Hi,I remember after read the source code, it was already a method exist in the base class or in the abstract method, you can just inherit and write your own clear logic with the FAISS package.Feel free to reach me if this doesn’t work.On Nov 24, 2024, at 05:33, Wendong Li ***@***.***> wrote:
Hi, I was also running to this issue. What happened to this PR next? Why was it closed? Thanks for your help.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:improvement
Medium size change to existing code to handle new use-cases
Ɑ: vector store
Related to vector store module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Description: In constructing the VectorStoreRetrieverMemory with InMemoryDocstore() like faiss vectorstore, it may also need to clear the chat_history memory like ConversationBufferMemory. To clear the memory without reconstruct a new memory, I add a clear() method to VectorStoreRetrieverMemory make it reusable in the same session, and can use memory.clear() to empty the memory vectorstore. < Only fot the FAISS vectorstore>
- Issue: the issue #5817 how to clear VectorStoreRetrieverMemory?
- Dependencies: None
- Tag maintainer:
- Twitter handle: @932196e6a7d042d
**- Usecase: **
@baskaryan