Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONLoader Documentation Fix #10505

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

amdmax
Copy link
Contributor

@amdmax amdmax commented Sep 12, 2023

  • Description:
    Updated JSONLoader usage documentation which was making it unusable
  • Issue: JSONLoader if used with the documented arguments was failing on various JSON documents.
  • Dependencies:
    no dependencies
  • Twitter handle: @TheSlnArchitect

If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17, @rlancemartin.
-->

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 8:10am

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Sep 12, 2023
@leo-gan
Copy link
Collaborator

leo-gan commented Sep 12, 2023

LGTM
@amdmax Thanks for fixing it!

@leo-gan leo-gan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 15, 2023
@baskaryan
Copy link
Collaborator

thanks @amdmax!

@baskaryan baskaryan merged commit 697efd9 into langchain-ai:master Sep 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants