Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of RecursiveUrlLoader's exclude_dirs #10578

Closed
wants to merge 3 commits into from
Closed

Fix typing of RecursiveUrlLoader's exclude_dirs #10578

wants to merge 3 commits into from

Conversation

ind1go
Copy link

@ind1go ind1go commented Sep 14, 2023 •
edited
Loading

  • Description: This fixes an issue in RecursiveUrlLoader where a typing appears to be incorrect. The exclude_dirs parameter is iterated over, yet is defined as Optional[str] - this PR changes that to Optional[Iterable[str]].
  • Issue: None - this is a find-and-fix.
  • Dependencies: None
  • Tag maintainer: Maybe @rlancemartin?
  • Twitter handle: @benc_uk

@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2023 6:13pm

@dosubot dosubot bot added Ɑ: doc loader Related to document loader module (not documentation) 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Sep 14, 2023
leo-gan
leo-gan approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@leo-gan leo-gan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leo-gan leo-gan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Sep 14, 2023
@hwchase17
Copy link
Contributor

closing because it was changed to sequence

@hwchase17 hwchase17 closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-gan leo-gan leo-gan approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: doc loader Related to document loader module (not documentation) lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ind1go @hwchase17 @leo-gan