Let Notion document loader support utf-8 and make it default. #10613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richarddwang
commented
Sep 15, 2023
richarddwang
commented
- Description: Let Notion document loader support utf-8 and make it default. Otherwise, it gets an error when reading non-English documents.
- Issue: Not applicable.
- Dependencies: None.
- Tag maintainer:
- Twitter handle: richarddwang
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
eyurtsev
reviewed
Oct 6, 2023
| @@ -8,16 +8,17 @@ | |||
| class NotionDirectoryLoader(BaseLoader): | |||
| """Load `Notion directory` dump.""" | |||
|
|
|||
| def __init__(self, path: str): | |||
| def __init__(self, path: str, encoding: str = 'utf-8'): | |||
There was a problem hiding this comment.
Suggested change
| def __init__(self, path: str, encoding: str = 'utf-8'): | |
| def __init__(self, path: str, *, encoding: str = 'utf-8'): |
|
@richarddwang this looks good, will merge once tests pass |
eyurtsev
approved these changes
Oct 6, 2023
eyurtsev
added
the
lgtm
|
Can merge after tests pass |
hoanq1811
pushed a commit
to hoanq1811/langchain
that referenced
this pull request
Feb 2, 2024
…ain-ai#10613) Use utf-8 encoding by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.