-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph_sparql_qa): return formatted SPARQL query on demand #11263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:enhancement
A large net-new component, integration, or chain. Use sparingly. The largest features
label
Oct 1, 2023
Apologies for the slow review! Pr has some merge conflicts, happy to re-review if you'd like to resolve |
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Feb 21, 2024
baskaryan
approved these changes
Feb 21, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Feb 21, 2024
al1p
pushed a commit
to al1p/langchain
that referenced
this pull request
Feb 27, 2024
…ai#11263) - **Description:** Added the `return_sparql_query` feature to the `GraphSparqlQAChain` class, allowing users to get the formatted SPARQL query along with the chain's result. - **Issue:** NA - **Dependencies:** None Note: I've ensured that the PR passes linting and testing by running make format, make lint, and make test locally. I have added a test for the integration (which relies on network access) and I have added an example to the notebook showing its use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:enhancement
A large net-new component, integration, or chain. Use sparingly. The largest features
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return_sparql_query
feature to theGraphSparqlQAChain
class, allowing users to get the formatted SPARQL query along with the chain's result.Note: I've ensured that the PR passes linting and testing by running make format, make lint, and make test locally.
I have added a test for the integration (which relies on network access) and I have added an example to the notebook showing its use.