Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current version supports any number of fields #12981

Closed
wants to merge 23 commits into from

Conversation

zhanghexian
Copy link
Contributor

The current version supports any number of fields

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 6:00am

@dosubot dosubot bot added Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Nov 7, 2023
@zhanghexian
Copy link
Contributor Author

zhanghexian commented Nov 7, 2023 via email

@hwchase17 hwchase17 closed this Jan 30, 2024
@baskaryan baskaryan reopened this Jan 30, 2024
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 2, 2024
@baskaryan
Copy link
Collaborator

@zhanghexian resolved all merge conflicts, does it still look good to you?

@zhanghexian
Copy link
Contributor Author

zhanghexian commented Apr 2, 2024 via email

@zhanghexian
Copy link
Contributor Author

zhanghexian commented Apr 2, 2024 via email

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 2, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 28, 2024
@zhanghexian
Copy link
Contributor Author

Hello, vearch vector database has made the latest adjustment according to the latest version of python sdk, please check it, thank you!

@zhanghexian
Copy link
Contributor Author

i am sorry,i can not find this file to slove it's problem(tests/unit_tests/vectorstores/test_public_api.py),and i found that lint rule of vearch.jupyter is different for different python version.Please tell me how to fix this ,thanks!

@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@ccurme
Copy link
Collaborator

ccurme commented Aug 12, 2024

i am sorry,i can not find this file to slove it's problem(tests/unit_tests/vectorstores/test_public_api.py),and i found that lint rule of vearch.jupyter is different for different python version.Please tell me how to fix this ,thanks!

Please see contributor guidelines here for formatting and linting.

@zhanghexian
Copy link
Contributor Author

zhanghexian commented Aug 12, 2024 via email

@efriis
Copy link
Member

efriis commented Dec 14, 2024

closing due to still failing CI. Would recommend checking out the docs chester posted if you want to reopen!

Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml, deprecating this community integration in favor of your integration package}

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

@efriis efriis closed this Dec 14, 2024
@zhanghexian
Copy link
Contributor Author

zhanghexian commented Dec 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants