Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LangChain: factory method to FileChatMessageHistory for use with RunnableWithMessageHistory (Improvement) #14265

Closed
wants to merge 5 commits into from
Closed

LangChain: factory method to FileChatMessageHistory for use with RunnableWithMessageHistory (Improvement) #14265

wants to merge 5 commits into from

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Dec 5, 2023 •
edited
Loading

This PR adds a bit of utility code to make it more convenient to use existing
file chat message history with RunnableWithMessageHistory.

  • Create a factory method that takes session id and creates a file chat message history

@vercel Vercel
Copy link

vercel bot commented Dec 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 4:44pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: memory Related to memory module 🤖:improvement Medium size change to existing code to handle new use-cases labels Dec 5, 2023
@eyurtsev eyurtsev changed the title Update file chat memory LangChain: Add session_id and factory method to FileChatMessageHistory (Improvement) Dec 5, 2023
@eyurtsev eyurtsev requested a review from baskaryan December 5, 2023 04:00
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented Dec 5, 2023 •
edited
Loading

I might change this tomorrow don't merge yet :) @baskaryan

@eyurtsev eyurtsev changed the title LangChain: Add session_id and factory method to FileChatMessageHistory (Improvement) LangChain: factory method to FileChatMessageHistory for use with RunnableWithMessageHistory (Improvement) Dec 5, 2023
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented Dec 6, 2023

Not going to merge in since it there's no obvious factory -- e.g., i used user_id and conversation_id in another PR In langserve, so closing for now

@eyurtsev eyurtsev closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan Awaiting requested review from baskaryan

Assignees
No one assigned
Labels
🤖:improvement Medium size change to existing code to handle new use-cases Ɑ: memory Related to memory module size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eyurtsev