Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error issue 12250 #14290

Closed
wants to merge 4 commits into from
Closed

fix error issue 12250 #14290

wants to merge 4 commits into from

Conversation

daniellefranca96
Copy link

Description: Correction of bug that make the predict method failed on VertexAI LLM.
Issue: #12250
Dependencies: none.
Tag maintainer: @hwchase17

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: models Related to LLMs or chat model modules 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Dec 5, 2023
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm but we explicitly have candidate_count as something in _default_params. We should seemingly remove that as well right?

@dosubot dosubot bot removed the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 7, 2023
Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 11, 2023 5:21am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 7, 2023
@daniellefranca96
Copy link
Author

daniellefranca96 commented Dec 7, 2023

@hwchase17 i removed the parameter n from VertexAI and ChatVertexAI

@daniellefranca96 daniellefranca96 closed this by deleting the head repository Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature Ɑ: models Related to LLMs or chat model modules size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants