-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core[patch], langchain[patch]: fix required deps #14373
Changes from 17 commits
60ada41
1950115
2d54b01
fb47535
4da0d29
3feb35c
5a435aa
df39d76
a6d91e6
1feacd1
d8716f2
0db9786
c9ac773
f167f64
95ca134
405b271
94cabdf
27db93b
b3a6c0a
66cc5ae
3351694
cc1c255
6f7fc12
567d620
af9ce99
90eac11
7c0f499
b573559
9c43c36
57a1b92
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import pytest | ||
|
||
|
||
@pytest.mark.compile | ||
def test_placeholder() -> None: | ||
"""Used for compiling integration tests without running any real tests.""" | ||
pass |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ | |
"Run", | ||
"RunLog", | ||
"RunLogPatch", | ||
"LogStreamCallbackHandler", | ||
] | ||
|
||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,7 +59,11 @@ def test_something(): | |
# If we haven't yet checked whether the pkg is installed | ||
# let's check it and store the result. | ||
if pkg not in required_pkgs_info: | ||
required_pkgs_info[pkg] = util.find_spec(pkg) is not None | ||
try: | ||
installed = util.find_spec(pkg) is not None | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. when does this result in an exception? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i think it works for top level packages without an error? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. was giving errors for "google": https://github.com/langchain-ai/langchain/actions/runs/7133277557/job/19425640725 but let me try again, maybe was symptom of different issue |
||
except Exception: | ||
installed = False | ||
required_pkgs_info[pkg] = installed | ||
|
||
if not required_pkgs_info[pkg]: | ||
if only_extended: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was linting messing up somehow?