Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core dependencies update #14407

Closed
wants to merge 3 commits into from

Conversation

leo-gan
Copy link
Collaborator

@leo-gan leo-gan commented Dec 7, 2023

Updated pyproject.toml with missed dependencies.
Several dependencies are missed in the pyproject.toml. They are explicitly imported in code.
I listed the files and code lines below.
Those packages are still presented in the poetry.lock. So, those missed dependencies do not break anything.
This update is for consistency. Every explicitly imported package should be presented in the dependency configuration.
Note: poetry.lock is updated because anyio version here (=>4.0 - from poetry.lock) conflicts with langchain version (<4.0)

langchain_core/language_models/llms.py:
langchain_core/prompts/base.py:
langchain_core/prompts/loading.py:
import yaml

langchain_core/output_parsers/base.py:
from typing_extensions import get_args

langchain_core/runnables/base.py:
from typing_extensions import Literal, get_args

langchain_core/runnables/config.py:
langchain_core/runnables/router.py:
from typing_extensions import TypedDict

langchain_core/utils/iter.py:
from typing_extensions import Literal

langchain_core/tracers/langchain_v1.py:
langchain_core/utils/loading.py:
import requests

langchain_core/utils/utils.py:
from requests import HTTPError, Response

langchain_core/tracers/log_stream.py:
from anyio import create_memory_object_stream

langchain_core/utils/utils.py:
from packaging.version import parse

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 6:45pm

@leo-gan leo-gan marked this pull request as ready for review December 7, 2023 18:49
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Dec 7, 2023
@leo-gan leo-gan requested review from hwchase17 and eyurtsev and removed request for hwchase17 December 7, 2023 18:49
@efriis
Copy link
Member

efriis commented Dec 7, 2023

I think this is duplicate work to #14373 , and I'll send this to @baskaryan to make sure the packaging+requests ones are handled properly

@efriis efriis closed this Dec 7, 2023
@efriis
Copy link
Member

efriis commented Dec 7, 2023

Great catches! He's adding them

@leo-gan leo-gan deleted the core-dependencies-update branch December 7, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants