Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectara summarization #14408

Closed
wants to merge 18 commits into from
Closed

Conversation

ofermend
Copy link
Contributor

@ofermend ofermend commented Dec 7, 2023

  • Description: Adding Summarization to Vectara, to reflect it provides not only vector-store type functionality but also can return a summary.
    Also added:
  • MMR capability (in the Vectara platform side)

  • Updated templates

  • Updated documentation and IPYNB examples

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2023 6:27pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Dec 7, 2023
@efriis
Copy link
Member

efriis commented Dec 7, 2023

Hey @ofermend ! We're currently splitting up integration packages, so would you be game to wait on this PR until next week, when you can put the PR up against the new location for these?

@ofermend
Copy link
Contributor Author

ofermend commented Dec 7, 2023

Sure. I've been working on this for last few days and also in parallel with Jacob on the JS version. Can wait with both until you are done with the split and then I assume there may be some fixes to do, but I hope nothing too bad.
Can you please ping me when I should take a look next week and refactor what's needed?

@ofermend
Copy link
Contributor Author

Hey @efriis - any updates on working to merge this in, post the refactor?
Also I noticed there was another PR for MMR that never got merged. This supercedes this and has the code for our internal MMR implementation so I think it's okay to close that other PR: #13571

@efriis efriis mentioned this pull request Dec 14, 2023
@efriis
Copy link
Member

efriis commented Dec 14, 2023

Yes! If you merge in master, you'll notice most of these files have moved to the langchain-community lib. If you could merge that in (it's all in master), that would be great!

More info if curious: #14243

@ofermend
Copy link
Contributor Author

Okay let me merge master in, move things around, and I'll test everything then update the PR
I noticed that self-query vectara remains in the original location - does that need to move to the new community location too?

@efriis
Copy link
Member

efriis commented Dec 15, 2023

Feel free to leave the self query one where it is for now - we'll handle that with the rest at that time.

@ofermend
Copy link
Contributor Author

@efriis - any updates on merging this in? Anything else missing?

@efriis
Copy link
Member

efriis commented Dec 20, 2023

I think it's just failing lint if you want to take a look!

@ofermend
Copy link
Contributor Author

fixed that lint issue. Anything else I'm missing?

@efriis
Copy link
Member

efriis commented Dec 20, 2023

It's still failing lint. I'll take a look later today! Make sure you're running mypy 0.0.991 and ruff 0.1.5 in community!

@ofermend
Copy link
Contributor Author

Thanks. Pls let me know. THe failures I see above are unrelated to Vectara (Power BI or something)

@efriis
Copy link
Member

efriis commented Dec 20, 2023

Assuming you didn't mean to change those files in this PR?

@ofermend
Copy link
Contributor Author

Not at all. Sorry maybe did so mistakenly during a previous "make format" that went bad?

@efriis
Copy link
Member

efriis commented Dec 20, 2023

Can't edit this branch. Merging in #14970

@efriis efriis closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants