-
Notifications
You must be signed in to change notification settings - Fork 16.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vectara summarization #14408
Vectara summarization #14408
Conversation
fixed bugs in mmr and updated tests
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @ofermend ! We're currently splitting up integration packages, so would you be game to wait on this PR until next week, when you can put the PR up against the new location for these? |
Sure. I've been working on this for last few days and also in parallel with Jacob on the JS version. Can wait with both until you are done with the split and then I assume there may be some fixes to do, but I hope nothing too bad. |
Yes! If you merge in master, you'll notice most of these files have moved to the langchain-community lib. If you could merge that in (it's all in master), that would be great! More info if curious: #14243 |
Okay let me merge master in, move things around, and I'll test everything then update the PR |
Feel free to leave the self query one where it is for now - we'll handle that with the rest at that time. |
@efriis - any updates on merging this in? Anything else missing? |
I think it's just failing lint if you want to take a look! |
fixed that lint issue. Anything else I'm missing? |
It's still failing lint. I'll take a look later today! Make sure you're running mypy 0.0.991 and ruff 0.1.5 in community! |
Thanks. Pls let me know. THe failures I see above are unrelated to Vectara (Power BI or something) |
Assuming you didn't mean to change those files in this PR? |
Not at all. Sorry maybe did so mistakenly during a previous "make format" that went bad? |
Can't edit this branch. Merging in #14970 |
Also added:
MMR capability (in the Vectara platform side)
Updated templates
Updated documentation and IPYNB examples