Update test_sql_database.py #17097
Update test_sql_database.py #17097
Conversation
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
🤖:nit
| @@ -77,7 +77,7 @@ def test_sql_database_sequential_chain_intermediate_steps() -> None: | |||
| db_chain = SQLDatabaseSequentialChain.from_llm( | |||
| OpenAI(temperature=0), db, return_intermediate_steps=True | |||
| ) | |||
| output = db_chain("What company does Harrison work at?") | |||
| output = db_chain.run("What company does Harrison work at?") | |||
There was a problem hiding this comment.
We generally prefer using .invoke rather than .run now
There was a problem hiding this comment.
@eyurtsev, Understood, I have updated PR with .invoke now with all the found code that should be modified with the same.
Thanks
There was a problem hiding this comment.
@eyurtsev, I also see that a lint error comes up with this change. It seems like .invoke is expecting a non-string data type value, maybe a dict type.
There was a problem hiding this comment.
@eyurtsev, What should we do here now, Based on the .invoke data type, .run can be implemented here. What's your suggestion?
There was a problem hiding this comment.
@eyurtsev, Just a reminder, Should we revoke from .invoke to .run now?
dosubot
bot
added
size:S
dosubot
bot
added
size:XS
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Error
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Failure
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Failure
baskaryan
had a problem deploying
to
Scheduled testing
GitHub Actions
Error
In the previous function, db_chain.run is used to execute the chain, but in line number 79, only db_chain is called, which can lead to code inefficiency because it doesn't actually execute the chain. To ensure consistency, it's important to use the .run method consistently to execute the chain in all relevant parts of the code.