Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Bug Fix, in Neo4j VectorStore when having multiple indexes the sort is not working and the store that returned is random #17396

Merged
merged 7 commits into from
Feb 22, 2024
Merged

community: Bug Fix, in Neo4j VectorStore when having multiple indexes the sort is not working and the store that returned is random #17396

merged 7 commits into from
Feb 22, 2024

Conversation

ehude
Copy link
Contributor

@ehude ehude commented Feb 12, 2024

Bug fix: when having multiple indexes the sort is not working and the store that returned is random.
The following small fix resolves the issue.

@ehude
Bug fix: when having multiple indexes the sort is not working and the…
7148039 
… store that returned is random.

The following small fix resolves the issue.
@vercel Vercel
Copy link

vercel bot commented Feb 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 21, 2024 7:01pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Feb 12, 2024
@baskaryan
Copy link
Collaborator

cc @tomasonjo

@tomasonjo
Copy link
Contributor

tomasonjo commented Feb 13, 2024 •
edited
Loading

@ehude looks ok. Can you please add a test. Can copy from here: #16505 or you can check the test I did in JS version: https://github.com/langchain-ai/langchainjs/pull/4390/files

@tomasonjo tomasonjo mentioned this pull request Feb 13, 2024
Merged
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 13, 2024
@ehude
Copy link
Contributor Author

ehude commented Feb 13, 2024

@tomasonjo thanks for the info.
I've added the relevant test, let me know if that is ok.

@tomasonjo
Copy link
Contributor

You need to create two indexes, but then use from_existing_index and check if it picked the correct one :)

@ehude
Copy link
Contributor Author

ehude commented Feb 13, 2024

make more sense indeed :)
fixed and pushed.

@tomasonjo
Copy link
Contributor

Awesome, thank you!

@ehude
Copy link
Contributor Author

ehude commented Feb 13, 2024 •
edited
Loading

Glad I could help :)
BTW, any idea when is the next release or where I can update on upcoming releases?

@tomasonjo
Copy link
Contributor

@ehude can you check the lint error, so that we can get this in? Thanks

@ehude
Copy link
Contributor Author

ehude commented Feb 17, 2024

@tomasonjo Sure, will fix it tomorrow

@ehude
Copy link
Contributor Author

ehude commented Feb 18, 2024

@tomasonjo
Pushed a fix and tested locally with make lint_package.
Please let me know if need to run anything else to check.

@tomasonjo
Copy link
Contributor

1 file would be reformatted, 599 files already formatted

seems like formatting is missing. If you run make format, it should be fixed.

@ehude
Copy link
Contributor Author

ehude commented Feb 20, 2024

done

@tomasonjo
Copy link
Contributor

Thanks @ehude . @baskaryan LGTM!

@tomasonjo
Copy link
Contributor

Can you move it from unit tests to integration tests, and then it should pass all checks :)

@ehude
Copy link
Contributor Author

ehude commented Feb 21, 2024

Thanks
Done :)

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 21, 2024
@baskaryan baskaryan merged commit 9e54c22 into langchain-ai:master Feb 22, 2024
57 checks passed
al1p pushed a commit to al1p/langchain that referenced this pull request Feb 27, 2024
@ehude @al1p-R
community[patch]: Bug Neo4j VectorStore when having multiple indexes …
9f06aaa 
…the sort is not working and the store that returned is random (langchain-ai#17396)

Bug fix: when having multiple indexes the sort is not working and the
store that returned is random.
The following small fix resolves the issue.
@jalakoo jalakoo mentioned this pull request Mar 12, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehude @baskaryan @tomasonjo