openai[patch]: pass message name #17537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
size:S
dosubot
bot
added
Ɑ: models
dosubot
bot
added
size:M
dosubot
bot
added
size:L
efriis
changed the title
efriis
commented
Feb 22, 2024
libs/partners/openai/pyproject.toml
Outdated
| @@ -12,7 +12,7 @@ license = "MIT" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8.1,<4.0" | |||
| langchain-core = "^0.1.16" | |||
| langchain-core = "^0.1.25" | |||
There was a problem hiding this comment.
had to bump core for basemessage.name
jacoblee93
reviewed
Feb 22, 2024
| message_dict["tool_call_id"] = message.tool_call_id | ||
|
|
||
| # tool message doesn't have name: https://platform.openai.com/docs/api-reference/chat/create#chat-create-messages | ||
| del message_dict["name"] |
There was a problem hiding this comment.
Should we log a warning here? Will OpenAI reject this?
There was a problem hiding this comment.
OpenAI rejects. Think I should raise an error?
There was a problem hiding this comment.
changed to pass through unless it's none
dosubot
bot
added
size:M
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this pull request
Mar 30, 2024
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.