Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain_core.tools.ToolException docs/exception message #17590

Merged
merged 33 commits into from
Mar 27, 2024

Conversation

kwehmeyer
Copy link
Contributor

@kwehmeyer kwehmeyer commented Feb 15, 2024

Description:
This PR adds a slightly more helpful message to a Tool Exception

# current state
langchain_core.tools.ToolException: Too many arguments to single-input tool

# proposed state
langchain_core.tools.ToolException: Too many arguments to single-input tool. Consider using a StructuredTool instead.

Issue: Somewhat discussed here 👉 #6197
Dependencies: None
Twitter handle: N/A

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 15, 2024
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 8:58pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Feb 15, 2024
@kwehmeyer
Copy link
Contributor Author

@baskaryan 🫡

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 20, 2024
@baskaryan baskaryan enabled auto-merge (squash) March 11, 2024 00:56
@kwehmeyer
Copy link
Contributor Author

@baskaryan what is preventing an automerge?

@baskaryan
Copy link
Collaborator

failing lint. so check locally run

cd libs/core
make format
make lint

auto-merge was automatically disabled March 27, 2024 20:57

Head branch was pushed to by a user without write access

@baskaryan baskaryan enabled auto-merge (squash) March 27, 2024 21:48
@baskaryan baskaryan merged commit 9c08cde into langchain-ai:master Mar 27, 2024
94 checks passed
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
**Description:**
This PR adds a slightly more helpful message to a Tool Exception

```
# current state
langchain_core.tools.ToolException: Too many arguments to single-input tool

# proposed state
langchain_core.tools.ToolException: Too many arguments to single-input tool. Consider using a StructuredTool instead.
```
**Issue:** Somewhat discussed here 👉  langchain-ai#6197 
 **Dependencies:** None
**Twitter handle:** N/A

---------

Co-authored-by: Bagatur <[email protected]>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
**Description:**
This PR adds a slightly more helpful message to a Tool Exception

```
# current state
langchain_core.tools.ToolException: Too many arguments to single-input tool

# proposed state
langchain_core.tools.ToolException: Too many arguments to single-input tool. Consider using a StructuredTool instead.
```
**Issue:** Somewhat discussed here 👉  #6197 
 **Dependencies:** None
**Twitter handle:** N/A

---------

Co-authored-by: Bagatur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants