community: Add initial tests for AzureSearch vector store #17663
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:L
|
@pamelafox had the idea to test this by manually reverting the following pr I can confirm these tests would catch the regression that PR fixed |
|
@baskaryan please take a look. It would be great to have some test coverage on the Azure Search vector store |
dosubot
bot
added
the
lgtm
|
Thanks @baskaryan I fixed how I was patching, hopefully the tests run now. |
|
still seeing some lint issues in community, you can run formatter linter locally with cd libs/community
poetry install --with lint,typing,test
make format
make lint |
|
FYI @baskaryan i think the build is stuck, but please take a look |
|
@mattgotteiner still some lint issues. you can run linter locally with cd libs/community
make format
make lintto see what's going on |
sorry I lost track of this. just tried to fix it |
|
@baskaryan this is finally passing CI. Please let me know if you can merge it |
|
Hi @baskaryan do you think you can please take another look? |
Base branch was modified
|
Hi @baskaryan any chance this PR can be merged? It's passing CI now. Please let me know |
|
Thanks! |
) **Description:** AzureSearch vector store has no tests. This PR adds initial tests to validate the code can be imported and used. **Issue:** N/A **Dependencies:** azure-search-documents and azure-identity are added as optional dependencies for testing --------- Co-authored-by: Matt Gotteiner <[email protected]> Co-authored-by: Bagatur <[email protected]>
…gchain-ai#17663) **Description:** AzureSearch vector store has no tests. This PR adds initial tests to validate the code can be imported and used. **Issue:** N/A **Dependencies:** azure-search-documents and azure-identity are added as optional dependencies for testing --------- Co-authored-by: Matt Gotteiner <[email protected]> Co-authored-by: Bagatur <[email protected]>
Description: AzureSearch vector store has no tests. This PR adds initial tests to validate the code can be imported and used.
Issue: N/A
Dependencies: azure-search-documents and azure-identity are added as optional dependencies for testing