Add JSON representation of runnable graph to serialized representation #17745

nfcampos · 2024-02-19T17:52:06Z

Sent to LangSmith

Thank you for contributing to LangChain!

Checklist:

PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
- Example: "community: add foobar LLM"
PR message: Delete this entire template message and replace it with the following bulleted list
- Description: a description of the change
- Issue: the issue # it fixes, if applicable
- Dependencies: any dependencies required for this change
- Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!
Pass lint and test: Run make format, make lint and make test from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/
Add tests and docs: If you're adding a new integration, please include
1. a test for the integration, preferably unit tests that do not rely on network access,
2. an example notebook showing its use. It lives in docs/docs/integrations directory.

Additional guidelines:

Make sure optional dependencies are imported within a function.
Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
Most PRs should not touch more than one package.
Changes should be backwards compatible.
If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

vercel · 2024-02-19T17:52:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchain	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 19, 2024 9:37pm

Sent to LangSmith

eyurtsev · 2024-02-20T19:09:13Z

libs/core/langchain_core/runnables/graph.py

+            "data": node_data_str(node),
+        }
+
+
 @dataclass
 class Graph:
    """Graph of nodes and edges."""

    nodes: Dict[str, Node] = field(default_factory=dict)
    edges: List[Edge] = field(default_factory=list)


Are edges in both directions allowed simultaneously?

i.e., if there's node 1 and 2

can we get edge 1 -> 2 and edge 2 -> 1 ?

In theory possible yea

eyurtsev · 2024-02-20T19:09:43Z

libs/core/langchain_core/runnables/graph.py

@@ -53,13 +149,13 @@ def remove_node(self, node: Node) -> None:
            if edge.source != node.id and edge.target != node.id
        ]

-    def add_edge(self, source: Node, target: Node) -> Edge:
+    def add_edge(self, source: Node, target: Node, data: Optional[str] = None) -> Edge:


Nit: I generally prefer * prior to all arguments with None defaults.

eyurtsev

This is such a neat feature!

baskaryan · 2024-02-20T19:40:15Z

libs/core/langchain_core/runnables/graph.py

 @dataclass
 class Graph:
    """Graph of nodes and edges."""

    nodes: Dict[str, Node] = field(default_factory=dict)
    edges: List[Edge] = field(default_factory=list)

+    def to_json(self) -> Dict[str, List[Dict[str, Any]]]:
+        """Convert the graph to a JSON-serializable format."""
+        stable_node_ids = {


what does stable mean here

ah ic, so that two graphs with equivalent objects and edges would have same serialization?

basically if you generate the same chain twice you should get same json graph

baskaryan · 2024-02-20T19:56:27Z

libs/core/langchain_core/runnables/graph.py

@@ -11,11 +12,20 @@
    from langchain_core.runnables.base import Runnable as RunnableType


unrelated but why the rename

does it cause issues when you actually import in functions

yea because I need to import the actual class inside a function

sploithunter · 2024-02-23T21:17:19Z

Does this indicate that graph will support a load from JSON?!?!?!

langchain-ai#17745) Sent to LangSmith Thank you for contributing to LangChain! Checklist: - [ ] PR title: Please title your PR "package: description", where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] PR message: **Delete this entire template message** and replace it with the following bulleted list - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] Pass lint and test: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified to check that you're passing lint and testing. See contribution guidelines for more information on how to write/run tests, lint, etc: https://python.langchain.com/docs/contributing/ - [ ] Add tests and docs: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 19, 2024

dosubot bot added 🤖:improvement Medium size change to existing code to handle new use-cases size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 19, 2024

vercel bot deployed to Preview February 19, 2024 20:44 View deployment

nfcampos mentioned this pull request Feb 19, 2024

Implement get_input_schema(), get_output_schema(), get_graph() for StateGraph, MessageGraph langchain-ai/langgraph#123

Merged

nfcampos added 12 commits February 19, 2024 13:27

Add JSON representation of runnable graph to serialized representation

0763f04

Sent to LangSmith

Lint

811d5ba

Fix import

b9e3de2

Update snapshots

1a167f4

Add name

526a307

Add more info

4922147

Optionally accept external node ids

33b0395

Update snapshots

82f70f3

Add optional edge data

0434f2e

Prevent overwriting node with existing id

f157117

Lint

a32e61d

Lint

dadf63f

vercel bot deployed to Preview February 19, 2024 21:28 View deployment

Update

b871c58

nfcampos force-pushed the nc/19feb/runnable-serializable-graph-json branch from a59a77f to b871c58 Compare February 19, 2024 21:30

vercel bot deployed to Preview February 19, 2024 21:37 View deployment

eyurtsev reviewed Feb 20, 2024

View reviewed changes

eyurtsev approved these changes Feb 20, 2024

View reviewed changes

dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Feb 20, 2024

baskaryan reviewed Feb 20, 2024

View reviewed changes

baskaryan approved these changes Feb 20, 2024

View reviewed changes

nfcampos merged commit 223e5ef into master Feb 20, 2024
76 checks passed

nfcampos deleted the nc/19feb/runnable-serializable-graph-json branch February 20, 2024 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add JSON representation of runnable graph to serialized representation #17745

Add JSON representation of runnable graph to serialized representation #17745

nfcampos commented Feb 19, 2024

vercel bot commented Feb 19, 2024 •

edited

Loading

eyurtsev Feb 20, 2024 •

edited

Loading

nfcampos Feb 20, 2024

eyurtsev Feb 20, 2024

eyurtsev left a comment

baskaryan Feb 20, 2024

baskaryan Feb 20, 2024

nfcampos Feb 20, 2024

baskaryan Feb 20, 2024

baskaryan Feb 20, 2024

nfcampos Feb 20, 2024

sploithunter commented Feb 23, 2024

		@@ -11,11 +12,20 @@
		from langchain_core.runnables.base import Runnable as RunnableType

Add JSON representation of runnable graph to serialized representation #17745

Add JSON representation of runnable graph to serialized representation #17745

Conversation

nfcampos commented Feb 19, 2024

vercel bot commented Feb 19, 2024 • edited Loading

eyurtsev Feb 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eyurtsev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sploithunter commented Feb 23, 2024

vercel bot commented Feb 19, 2024 •

edited

Loading

eyurtsev Feb 20, 2024 •

edited

Loading