Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: added the possibility to return document ids as part of the results of similarity search in vectorstore chroma #17938

Closed
wants to merge 4 commits into from
Closed

community: added the possibility to return document ids as part of the results of similarity search in vectorstore chroma #17938

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd5b188
Added the possibility to return document ids within similary search
majdabd Feb 22, 2024
7a0da5d
Merge branch 'master' into similarity_search_with_id
majdabd Feb 23, 2024
e1c5b17
Merge branch 'master' into majdabd/similarity_search_with_id
baskaryan Mar 29, 2024
f553868
fmt
baskaryan Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libs/community/langchain_community/vectorstores/chroma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,17 @@ def _results_to_docs_and_scores(results: Any) -> List[Tuple[Document, float]]:
return [
# TODO: Chroma can do batch querying,
# we shouldn't hard code to the 1st result
(Document(page_content=result[0], metadata=result[1] or {}), result[2])
(
Document(
page_content=result[0], metadata=(result[1] | {"id": result[3]}) or {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like if you have metadata it will override an id prop... can we think of a different way to handle this? i think it may really confuse some users, albeit an edge case

),
result[2],
)
for result in zip(
results["documents"][0],
results["metadatas"][0],
results["distances"][0],
results["ids"][0],
)
]

Expand Down
Loading