indexes refactoring
#18146
indexes refactoring
#18146
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| """Number of skipped documents because they were already up to date.""" | ||
|
|
||
|
|
||
| def index( |
There was a problem hiding this comment.
index should stay in langchain -- since partner packages may introduce a record manager implementation and we don't want partner packages to ever depend on langchain_community
| NAMESPACE_UUID = uuid.UUID(int=1984) | ||
|
|
||
|
|
||
| class RecordManager(ABC): |
There was a problem hiding this comment.
This should stay in langchain or end up in langchain core since partner packages will need to inherit for their own implementations.
Generally abstract interfaces should be in either langchain core or langchain, but not in langchain community
There was a problem hiding this comment.
@eyurtsev Yeah, exactly, that was implemented in the #17832 but @baskaryan opposed it. So...
looks like you and @baskaryan should decide what to do or not to do. I'm pausing now with this PR.
|
Close temporarily till the dependency rules are clear. |
|
Created this from referencing the refactor #20667 |
indexesatifacts partially duplicted in thelangchainand inlangchain_communitypackages.Regarding #17832 and following @baskaryan recommendations,
indexesis moved into thelangchain_community.All ut-s in
langchainwork without changes.Missed ut-s from
langchainwere added into thelangchain_communityut-s. Only ut-s that test the "all" symbol were not added, because "allinlangchain_community` is not used.