Community patch clickhouse make it possible to not specify index #20460
+53
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch-clickhouse-make-it-possible-to-not-specify-index
…ossible-to-not-specify-index
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: vector store
…e-to-not-specify-index
…e-to-not-specify-index
|
@efriis can you get the build to run on this version of the PR? |
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
|
@efriis did you get a chance to look at this? |
…e-to-not-specify-index
|
@efriis would you be able to kick off the build so that we can see if these changes work? |
…e-to-not-specify-index
…e-to-not-specify-index
|
@efriis any chance you can take a look at this? |
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
…e-to-not-specify-index
dosubot
bot
added
the
lgtm
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
) Vector indexes in ClickHouse are experimental at the moment and can sometimes break/change behaviour. So this PR makes it possible to say that you don't want to specify an index type. Any queries against the embedding column will be brute force/linear scan, but that gives reasonable performance for small-medium dataset sizes. --------- Co-authored-by: Erick Friis <[email protected]> Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector indexes in ClickHouse are experimental at the moment and can sometimes break/change behaviour. So this PR makes it possible to say that you don't want to specify an index type.
Any queries against the embedding column will be brute force/linear scan, but that gives reasonable performance for small-medium dataset sizes.
Previous PRs:
#19527
#18381