Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic info to metadata, classified by pebblo-server. #20468

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

rahul-trip
Copy link
Contributor

Description: Add support for Semantic topics and entities. Classification done by pebblo-server is not used to enhance metadata of Documents loaded by document loaders.
Dependencies: None
Documentation: Updated.

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 5:49am

@rahul-trip rahul-trip force-pushed the rahul_semantic_metadata branch from 10940bc to 6b987d4 Compare April 15, 2024 14:33
@rahul-trip rahul-trip marked this pull request as ready for review April 17, 2024 03:49
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 17, 2024
@rahul-trip rahul-trip force-pushed the rahul_semantic_metadata branch from 6b987d4 to 2db07c9 Compare April 17, 2024 04:30
@rahul-trip rahul-trip force-pushed the rahul_semantic_metadata branch from 2db07c9 to c7f9d21 Compare April 20, 2024 12:33
@rahul-trip rahul-trip force-pushed the rahul_semantic_metadata branch from c7f9d21 to 7b41691 Compare April 22, 2024 16:06
@rahul-trip
Copy link
Contributor Author

@baskaryan, @eyurtsev
@maintainers: Kindly review.

@@ -43,22 +44,25 @@ def __init__(
owner: str = "",
description: str = "",
api_key: Optional[str] = None,
load_semantic: Optional[bool] = False,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't need to be Optional[bool] can just be bool

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 25, 2024
@baskaryan baskaryan merged commit dc921f0 into langchain-ai:master Apr 25, 2024
62 checks passed
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…-server. (#20468)

Description: Add support for Semantic topics and entities.
Classification done by pebblo-server is not used to enhance metadata of
Documents loaded by document loaders.
Dependencies: None
Documentation: Updated.

Signed-off-by: Rahul Tripathi <[email protected]>
Co-authored-by: Rahul Tripathi <[email protected]>
pprados pushed a commit to pprados/langchain that referenced this pull request Apr 26, 2024
…-server. (langchain-ai#20468)

Description: Add support for Semantic topics and entities.
Classification done by pebblo-server is not used to enhance metadata of
Documents loaded by document loaders.
Dependencies: None
Documentation: Updated.

Signed-off-by: Rahul Tripathi <[email protected]>
Co-authored-by: Rahul Tripathi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: doc loader Related to document loader module (not documentation) 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants