Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prompt.py #20696

Closed
wants to merge 2 commits into from
Closed

Update prompt.py #20696

wants to merge 2 commits into from

Conversation

c-daniele
Copy link

@c-daniele c-daniele commented Apr 20, 2024

The current prompt is working properly with just OpenAI LLM. I've made several tests using other models like LLAMA2, Claude2 and Claude3. They all broke down with the "No Connection Adapter" error. I've then realized that it's just a minor issue in the URL prompt.

With this small prompt fine tuning, the APIChain will work on LLAMA2 and Claude also.

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
    • Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!
  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, hwchase17.

The current prompt is working properly with just OpenAI LLM.
I've made several tests using other models like LLAMA2, Claude2 and Claude3. They all broke down with the "No Connection Adapter" error.
I've then realized that it's just a PROMPT minor issue in the URL prompt. 

With this small prompt fine tuning, the APIChain will work on LLAMA2 and Claude also.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 20, 2024
Copy link

vercel bot commented Apr 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 11:00pm

@dosubot dosubot bot added 🔌: openai Primarily related to OpenAI integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 20, 2024
Copy link
Collaborator

@baskaryan baskaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we try not to update default prompts as that can lead to silent changes in behavior

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 6, 2024
@hwchase17
Copy link
Contributor

actually, per @baskaryan comment we try not to update these prompts

@hwchase17 hwchase17 closed this May 6, 2024
@c-daniele c-daniele deleted the patch-1 branch May 7, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: openai Primarily related to OpenAI integrations size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants