core[minor],langchain[patch],community[patch]: Move storage interfaces to core #20750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eyurtsev
commented
Apr 22, 2024
eyurtsev
commented
- Move storage interface to core
- Move in memory and file system implementation to core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:XL
efriis
reviewed
Apr 23, 2024
libs/core/langchain_core/stores.py
Outdated
| @@ -123,3 +129,292 @@ async def ayield_keys( | |||
|
|
|||
|
|
|||
| ByteStore = BaseStore[str, bytes] | |||
|
|
|||
|
|
|||
| class LocalFileStore(ByteStore): | |||
There was a problem hiding this comment.
feel pretty strongly this shouldn't be in core. Maybe a langchain-fs package. Or just in community.
Feels too easy of a target for vulnerabilities.
There was a problem hiding this comment.
langchain-fs works
| yield str(relative_path) | ||
|
|
||
|
|
||
| class InMemoryBaseStore(BaseStore[str, V], Generic[V]): |
There was a problem hiding this comment.
this is fine in core too. But if we're doing in memory implementations of everything, could also put all these in a langchain-inmemory implementation package
There was a problem hiding this comment.
IMO core might make more sense since the in memory abstraction is useful for testing of core itself
dosubot
bot
added
size:L
baskaryan
reviewed
Apr 24, 2024
|
|
||
| .. code-block:: python | ||
|
|
||
| from langchain.storage import InMemoryStore |
baskaryan
approved these changes
Apr 24, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.