Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[patch]: Update evaluation logic that instantiates a default LLM #20760

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

eyurtsev
Copy link
Collaborator

Favor langchain_openai over langchain_community for evaluation logic.

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 2:57pm

@eyurtsev eyurtsev requested a review from hinthornw April 22, 2024 21:06
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🔌: openai Primarily related to OpenAI integrations 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 22, 2024
@@ -27,6 +25,10 @@
from langchain.evaluation.schema import LLMEvalChain, PairwiseStringEvaluator
from langchain.schema import RUN_KEY

if TYPE_CHECKING:
from langchain_community.chat_models.azure_openai import AzureChatOpenAI
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to do another pass on this in a bit for now just changing into a type checking dep

libs/langchain/langchain/evaluation/loading.py Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 22, 2024
@eyurtsev eyurtsev merged commit a7c347a into master Apr 23, 2024
42 checks passed
@eyurtsev eyurtsev deleted the eugene/fix_default_model_in_langsmith branch April 23, 2024 20:09
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
… LLM (#20760)

Favor langchain_openai over langchain_community for evaluation logic.

---------

Co-authored-by: ccurme <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. 🔌: openai Primarily related to OpenAI integrations size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants