-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
langchain[patch]: Update evaluation logic that instantiates a default LLM #20760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
🔌: openai
Primarily related to OpenAI integrations
🤖:improvement
Medium size change to existing code to handle new use-cases
labels
Apr 22, 2024
eyurtsev
commented
Apr 22, 2024
@@ -27,6 +25,10 @@ | |||
from langchain.evaluation.schema import LLMEvalChain, PairwiseStringEvaluator | |||
from langchain.schema import RUN_KEY | |||
|
|||
if TYPE_CHECKING: | |||
from langchain_community.chat_models.azure_openai import AzureChatOpenAI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to do another pass on this in a bit for now just changing into a type checking dep
ccurme
approved these changes
Apr 22, 2024
dosubot
bot
added
the
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
label
Apr 22, 2024
Co-authored-by: ccurme <[email protected]>
efriis
approved these changes
Apr 23, 2024
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
… LLM (#20760) Favor langchain_openai over langchain_community for evaluation logic. --------- Co-authored-by: ccurme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🤖:improvement
Medium size change to existing code to handle new use-cases
lgtm
PR looks good. Use to confirm that a PR is ready for merging.
🔌: openai
Primarily related to OpenAI integrations
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Favor langchain_openai over langchain_community for evaluation logic.