Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[major]: Remove default instantations of LLMs from VectorstoreToolkit #20794

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

eyurtsev
Copy link
Collaborator

Remove default instantiation from vectorstore toolkit.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 3:50pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:improvement Medium size change to existing code to handle new use-cases labels Apr 23, 2024
@@ -255,6 +250,14 @@ def from_llm(
Returns:
FlareChain class with the given language model.
"""
try:
from langchain_openai import OpenAI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add community backup too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think so since we don't want to recommend community?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Apr 23, 2024
@eyurtsev eyurtsev merged commit 72f720f into master Apr 23, 2024
42 checks passed
@eyurtsev eyurtsev deleted the eugene/breakstore_toolkit branch April 23, 2024 20:09
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
…reToolkit (#20794)

Remove default instantiation from vectorstore toolkit.
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented May 3, 2024

#21080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants