[draft]: propagate score through retriever #20800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
efriis
reviewed
Apr 23, 2024
| query: str, | ||
| *, | ||
| run_manager: CallbackManagerForRetrieverRun, | ||
| include_score: bool = False, | ||
| ) -> List[Document]: | ||
| if self.search_type == "similarity": |
There was a problem hiding this comment.
this case feels like it could lead to some confusion. Should we throw an error if include_score is set to true in this case with a message to switch search type?
Also do we want to use relevance scores for this, or do we want to just return raw scores? My goal was to deprecate the relevance score stuff as-is in #20302
There was a problem hiding this comment.
Might also be good to add a typing override such that when include_score is set to true, this returns DocumentSearchHit. Alternative is to just add the score stuff as an optional to Document.
ccurme
temporarily deployed
to
Scheduled testing
GitHub Actions
Inactive
ccurme
temporarily deployed
to
Scheduled testing
GitHub Actions
Inactive
ccurme
temporarily deployed
to
Scheduled testing
GitHub Actions
Inactive
ccurme
added
community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.