perplexity[patch]: standardize chat init args #20844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
|
@baskaryan related to 20085, let me know if you would like any changes. My first attempted contribution :) |
eyurtsev
approved these changes
Apr 24, 2024
dosubot
bot
added
the
lgtm
eyurtsev
reviewed
Apr 24, 2024
| """Base URL path for API requests, | ||
| leave blank if not using a proxy or service emulator.""" | ||
| request_timeout: Optional[Union[float, Tuple[float, float]]] = None | ||
| request_timeout: Optional[Union[float, Tuple[float, float]]] = Field( |
There was a problem hiding this comment.
Run make format to prettify the content
There was a problem hiding this comment.
Thanks @eyurtsev just ran ruff on the file, and updated the pull request.
baskaryan
approved these changes
Apr 24, 2024
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
Thank you for contributing to LangChain! community:perplexity[patch]: standardize init args updated pplx_api_key and request_timeout so that aliased to api_key, and timeout respectively. Added test that both continue to set the same underlying attributes. Related to [20085](#20085) --------- Co-authored-by: Bagatur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to LangChain!
community:perplexity[patch]: standardize init args
updated pplx_api_key and request_timeout so that aliased to api_key, and timeout respectively. Added test that both continue to set the same underlying attributes.
Related to 20085