Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[patch],community[minor]: Move WebResearchRetriever #20847

Closed
wants to merge 3 commits into from

Conversation

eyurtsev
Copy link
Collaborator

Move web research retriever

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 6:09pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: retriever Related to retriever module 🤖:refactor A large refactor of a feature(s) or restructuring of many files labels Apr 24, 2024
@eyurtsev eyurtsev requested a review from jacoblee93 April 24, 2024 18:07
vectorstore: VectorStore = Field(
..., description="Vector store for storing web pages"
)
llm_chain: LLMChain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we should just change this typing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also has google search API wrapper dep

@eyurtsev eyurtsev closed this May 2, 2024
@eyurtsev
Copy link
Collaborator Author

eyurtsev commented May 2, 2024

Closing because i'm tackling this on another branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:refactor A large refactor of a feature(s) or restructuring of many files Ɑ: retriever Related to retriever module size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants