Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community:everlyai[patch]: standardize init args #22098

Closed

Conversation

ColeEnyart
Copy link

Patch Summary


community:everlyai[patch]: standardize init args

Updated everlyai_api_key to have alias api_key and configured pydantic to allow field names for ChatEverlyAI class. Added unit testing for Everly AI Chat for api_key usage.

Related to Standardized model init arg names #20085

Details


File: libs/community/langchain_community/chat_models/everlyai.py
Changes:

  • everlyai_api_key alias api_key
  • allow_population_by_field_name = True

File: libs/community/tests/unit_tests/chat_models/test_everlyai.py
Changes:

  • test missing API key
  • test default parameters
  • test parameter API key instead of environment API key
  • test parameter names can be referenced by alias

Updated everlyai_api_key to have alias api_key and configured pydantic to allow field names for ChatEverlyAI class. Added unit testing for Everly AI Chat for api_key usage.

Related to [20085](langchain-ai#20085)
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 23, 2024
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 9:47pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label May 23, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 23, 2024
@baskaryan baskaryan removed the lgtm PR looks good. Use to confirm that a PR is ready for merging. label May 23, 2024
@ColeEnyart ColeEnyart requested a review from baskaryan May 23, 2024 23:22
@ccurme ccurme added the community Related to langchain-community label Jun 18, 2024
@ccurme
Copy link
Collaborator

ccurme commented Aug 23, 2024

Believe this was implemented separately in #14293. Thanks for the fix. Let me know if it's not resolved.

@ccurme ccurme closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants