Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard-tests[patch]: update groq and structured output test #24781

Merged
merged 3 commits into from
Jul 29, 2024
Merged

standard-tests[patch]: update groq and structured output test #24781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6dbe5a
remove mixtral and update llama to 3.1
ccurme Jul 29, 2024
f7d139f
.schema is deprecated
ccurme Jul 29, 2024
8e057fb
add rate limiter for llama 3.1
ccurme Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 7 additions & 23 deletions libs/partners/groq/tests/integration_tests/test_standard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,15 @@

import pytest
from langchain_core.language_models import BaseChatModel
from langchain_standard_tests.integration_tests import ( # type: ignore[import-not-found]
ChatModelIntegrationTests, # type: ignore[import-not-found]
from langchain_core.rate_limiters import InMemoryRateLimiter
from langchain_standard_tests.integration_tests import (
ChatModelIntegrationTests,
)

from langchain_groq import ChatGroq

rate_limiter = InMemoryRateLimiter(requests_per_second=0.45)


class BaseTestGroq(ChatModelIntegrationTests):
@property
Expand All @@ -21,32 +24,13 @@ def test_tool_message_histories_list_content(self, model: BaseChatModel) -> None
super().test_tool_message_histories_list_content(model)


class TestGroqMixtral(BaseTestGroq):
@property
def chat_model_params(self) -> dict:
return {
"temperature": 0,
}

@pytest.mark.xfail(
reason=("Fails with 'Failed to call a function. Please adjust your prompt.'")
)
def test_structured_output(self, model: BaseChatModel) -> None:
super().test_structured_output(model)

@pytest.mark.xfail(
reason=("May pass arguments: {'properties': {}, 'type': 'object'}")
)
def test_tool_calling_with_no_arguments(self, model: BaseChatModel) -> None:
super().test_tool_calling_with_no_arguments(model)


class TestGroqLlama(BaseTestGroq):
@property
def chat_model_params(self) -> dict:
return {
"model": "llama3-8b-8192",
"model": "llama-3.1-8b-instant",
"temperature": 0,
"rate_limiter": rate_limiter,
}

@pytest.mark.xfail(
Expand Down
2 changes: 1 addition & 1 deletion libs/standard-tests/langchain_standard_tests/integration_tests/chat_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ class Joke(BaseModelProper):
assert isinstance(chunk, Joke)

# Schema
chat = model.with_structured_output(Joke.schema())
chat = model.with_structured_output(Joke.model_json_schema())
result = chat.invoke("Tell me a joke about cats.")
assert isinstance(result, dict)
assert set(result.keys()) == {"setup", "punchline"}
Expand Down
Loading