Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard-tests: set integration test parameters independent of unit test #24979

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Aug 2, 2024

This ends up getting set in integration tests.

Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 3:30pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Aug 2, 2024
@ccurme ccurme requested review from baskaryan and efriis and removed request for baskaryan August 2, 2024 15:19
@ccurme ccurme changed the title standard-tests: increase max_tokens standard-tests: set integration test parameters independent of unit test Aug 2, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Might be worth adding "model": "mistral-small" to demonstrate desired behavior of passing explicit model

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 2, 2024
@efriis
Copy link
Member

efriis commented Aug 2, 2024

Read it wrong. This is general not mistral

@efriis efriis merged commit c04d95b into master Aug 2, 2024
101 of 105 checks passed
@efriis efriis deleted the cc/standard_tests branch August 2, 2024 17:40
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants