-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added FalkorDB vector store support i.e implementation, test, docs an… #26245
added FalkorDB vector store support i.e implementation, test, docs an… #26245
Conversation
…d example notebook.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments also maybe run a formatter to many empty lines
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/tests/integration_tests/vectorstores/test_falkordbvector.py
Outdated
Show resolved
Hide resolved
libs/community/tests/integration_tests/vectorstores/test_falkordbvector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/tests/integration_tests/vectorstores/test_falkordbvector.py
Outdated
Show resolved
Hide resolved
libs/community/tests/integration_tests/vectorstores/test_falkordbvector.py
Outdated
Show resolved
Hide resolved
libs/community/tests/integration_tests/vectorstores/test_falkordbvector.py
Outdated
Show resolved
Hide resolved
( | ||
Document(metadata={'text': 'foo', 'id': 'acbd18db4cc2f85cedef654fccc4a4d8', 'page': '0'}, | ||
page_content='foo'), | ||
0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that the expected score ?
does the score is actually the distance from the query ?
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
libs/community/langchain_community/vectorstores/falkordb_vector.py
Outdated
Show resolved
Hide resolved
Thank you both for your valuable feedback on my initial commit. I’ve taken your suggestions into account and have made the necessary adjustments in this new commit (ed2e518). I would greatly appreciate it if you could take a moment to review the changes. Thanks again for your help! Also about the online meeting we can have it anytime between 12 pm to 6 pm WAT. My Email: [email protected] or [email protected] |
@baskaryan can you please merge this PR? |
@baskaryan Please Merge this pull request |
Please @baskaryan How long are the |
@kingtroga Can you look at the CI errors and fix them? |
@AviAvni On it |
@baskaryan can you please re-trigger the CI? |
😌 |
hey there! had to revert a few things that we don't accept (this added a hard dependency on Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/ |
@efriss Thank you!!! |
Description: Added support for FalkorDB Vector Store, including its implementation, unit tests, documentation, and an example notebook. The FalkorDB integration allows users to efficiently manage and query embeddings in a vector database, with relevance scoring and maximal marginal relevance search. The following components were implemented:
Twitter handle: @tariyekorogha