Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added FalkorDB vector store support i.e implementation, test, docs an… #26245

Merged
merged 45 commits into from
Dec 16, 2024

Conversation

kingtroga
Copy link
Contributor

Description: Added support for FalkorDB Vector Store, including its implementation, unit tests, documentation, and an example notebook. The FalkorDB integration allows users to efficiently manage and query embeddings in a vector database, with relevance scoring and maximal marginal relevance search. The following components were implemented:

  • Core implementation for FalkorDBVector store.
  • Unit tests ensuring proper functionality and edge case coverage.
  • Example notebook demonstrating an end-to-end setup, search, and retrieval using FalkorDB.

Twitter handle: @tariyekorogha

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:37pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Sep 10, 2024
Copy link

@AviAvni AviAvni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments also maybe run a formatter to many empty lines

(
Document(metadata={'text': 'foo', 'id': 'acbd18db4cc2f85cedef654fccc4a4d8', 'page': '0'},
page_content='foo'),
0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that the expected score ?
does the score is actually the distance from the query ?

@kingtroga
Copy link
Contributor Author

@swilly22 @AviAvni

Thank you both for your valuable feedback on my initial commit. I’ve taken your suggestions into account and have made the necessary adjustments in this new commit (ed2e518). I would greatly appreciate it if you could take a moment to review the changes.

Thanks again for your help!

Also about the online meeting we can have it anytime between 12 pm to 6 pm WAT. My Email: [email protected] or [email protected]

@gkorland
Copy link
Contributor

@baskaryan can you please merge this PR?

@kingtroga
Copy link
Contributor Author

@baskaryan Please Merge this pull request

@kingtroga
Copy link
Contributor Author

Please @baskaryan How long are the build, CI Success, and (Check for spelling errors) checks going to take?

@AviAvni
Copy link

AviAvni commented Sep 25, 2024

@kingtroga Can you look at the CI errors and fix them?

@kingtroga
Copy link
Contributor Author

@AviAvni On it

@gkorland
Copy link
Contributor

gkorland commented Oct 6, 2024

@baskaryan can you please re-trigger the CI?

@kingtroga
Copy link
Contributor Author

😌
image
@baskaryan PLEASE 🙏🏾 merge this pull request

@efriis
Copy link
Member

efriis commented Dec 14, 2024

hey there! had to revert a few things that we don't accept (this added a hard dependency on redis before). Hopefully it passes CI and can merge then.

Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml, deprecating this community integration in favor of your integration package}

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

@efriis efriis merged commit d262d41 into langchain-ai:master Dec 16, 2024
21 checks passed
@kingtroga
Copy link
Contributor Author

@efriss Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants