Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community: added audio-parser RemoteFasterWhisperParser in audio.py #26638

Closed
wants to merge 5 commits into from

Conversation

lfenzo
Copy link

@lfenzo lfenzo commented Sep 18, 2024

Description

This PR introduces a new audio parser to Langchain that allows interaction with Faster Whisper running in a remote server. This enhancement addresses a significant issue with the current Faster Whisper integration, which requires the Langchain process to have all necessary GPU drivers and dependencies installed locally. In microservice-based architectures, this leads to heavy and redundant dependencies in the Langchain container, making deployment more complex and resource-intensive.

Solution

This PR solves this issue by introducing a remote audio parser that can communicate with faster-whisper-server running in a dedicated container. This allows Langchain to delegate audio transcription tasks to this remote server, eliminating the need for GPU dependencies within the Langchain container itself reducing its dependency footprint.

The implementation relies on Python's built-in subprocess module to handle communication with the remote server, ensuring that no extra dependencies are introduced in Langchain.


cc.: @eyurtsev

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 10:14pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community labels Sep 18, 2024
@lfenzo lfenzo changed the title feat(parser, audio): added audio-parser RemoteFasterWhisperPerser in audio.py feat(parser, audio): added audio-parser RemoteFasterWhisperParser in audio.py Sep 18, 2024
@lfenzo lfenzo force-pushed the remote-faster-whisper branch from 58d08f2 to 362ea98 Compare September 19, 2024 12:05
@lfenzo lfenzo force-pushed the remote-faster-whisper branch from 362ea98 to 581115a Compare September 19, 2024 12:19
@lfenzo
Copy link
Author

lfenzo commented Sep 23, 2024

@baskaryan

@lfenzo
Copy link
Author

lfenzo commented Oct 1, 2024

@efriis

@efriis
Copy link
Member

efriis commented Oct 31, 2024

Marking as stale and still in need of support, per the review process

@lfenzo lfenzo force-pushed the remote-faster-whisper branch 3 times, most recently from adb3287 to 78576cf Compare November 10, 2024 00:47
@lfenzo lfenzo force-pushed the remote-faster-whisper branch from 78576cf to 9ff7392 Compare November 10, 2024 00:51
@lfenzo lfenzo changed the title feat(parser, audio): added audio-parser RemoteFasterWhisperParser in audio.py Community: added audio-parser RemoteFasterWhisperParser in audio.py Nov 10, 2024
RuntimeError: If the transcription process fails.
"""

process = subprocess.Popen(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately this isn't acceptable for security reasons, so will close!

@efriis efriis closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants