Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FalkorDB Chat History Support i.e implemenation, tests, and example notebook #26657

Closed
wants to merge 32 commits into from
Closed

Added FalkorDB Chat History Support i.e implemenation, tests, and example notebook #26657

wants to merge 32 commits into from

Conversation

kingtroga
Copy link
Contributor

  • Implemented FalkorDBChatMessageHistory for session-based message storage and retrieval in FalkorDB.
  • Added integration tests for adding, retrieving, and clearing chat messages.
  • Introduced support for using custom FalkorDB graph objects.
  • Provided an example notebook demonstrating the usage of FalkorDB Chat History in LangChain.

Twitter: @tariyekorogha

@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 0:20am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community labels Sep 19, 2024
@kingtroga
Copy link
Contributor Author

@baskaryan

@efriis
Copy link
Member

efriis commented Oct 31, 2024

Marking as stale and still in need of support, per the review process

@gkorland
Copy link
Contributor

@efriis why did you mark it as stale?
We would love to see the PR merged? Anything you see missing?

@kingtroga
Copy link
Contributor Author

kingtroga commented Nov 1, 2024 •
edited
Loading

@efriis What's wrong? I'm ready to rewrite this entire pr if that's the issue

@kingtroga
Copy link
Contributor Author

@efriis can you please merge the PR?

@kingtroga
Copy link
Contributor Author

@efriis can you please merge the PR?

@kingtroga
Copy link
Contributor Author

@efriis can you please merge the PR?

@kingtroga
Copy link
Contributor Author

@efriis

@kingtroga
Copy link
Contributor Author

@baskaryan

@kingtroga
Copy link
Contributor Author

@efriis

@efriis
Copy link
Member

efriis commented Dec 4, 2024

hey there! This actually isn't mergable because of the added required redis dependency to community.

Going to close this. If you're interested in publishing an external package with falkordb integrations that is self-managed (such that we don't get stuck in the same review queue as here), would recommend following this guide! https://python.langchain.com/docs/contributing/how_to/integrations/

@efriis efriis closed this Dec 4, 2024
@kingtroga
Copy link
Contributor Author

@efriis Alright, thank you for your time. Quick question though, If I make this exact PR without the Redis dependency would you merge it?

@kingtroga kingtroga mentioned this pull request Dec 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galshubeli galshubeli galshubeli approved these changes

@AviAvni AviAvni AviAvni approved these changes

@gkorland gkorland gkorland approved these changes

Assignees

@efriis efriis

Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files.
Projects
PR Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kingtroga @efriis @gkorland @AviAvni @galshubeli