Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Resolve Pydantic AttributeError in document_loaders/youtube.py #27322

Closed
wants to merge 2 commits into from

Conversation

TupleType
Copy link
Contributor

This error is thrown when upgrading to the latest langchain version:

if not values.get("credentials_path") and not values.get(
           ^^^^^^^^^^
AttributeError: 'pydantic_core._pydantic_core.ArgsKwargs' object has no attribute 'get'

I tested the fix locally

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 13, 2024
Copy link

vercel bot commented Oct 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 10:14am

@dosubot dosubot bot added community Related to langchain-community 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Oct 13, 2024
@TupleType
Copy link
Contributor Author

TupleType commented Oct 27, 2024

Hey @eyurtsev , could you please review?

@eyurtsev
Copy link
Collaborator

Hi @TupleType,

It's unclear to me what problem this PR addresses since no unit tests are included and no code to reproduce is included.

Ideally the solution doesn't involve Using ArgsKwargs -- we don't want to include too many special pydantic features as they increase the odds of bugs down the road and require developers to learn additional features.

Copy link
Collaborator

@eyurtsev eyurtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear what issue is being fixed. Need better example to reproduce ideally in the form of a unit test

@eyurtsev
Copy link
Collaborator

eyurtsev commented Dec 9, 2024

Closing due to no activity @TupleType feel free to re-open if this is still needed!

@eyurtsev eyurtsev closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature community Related to langchain-community size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants