community: fix @embeddingKey in azure cosmos db no sql #27377
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
|
when it will be merged? |
I am no expert so anyone should feel free to correct me. But it seems the status "Needs support" means that the PR is on hold until it reaches more engagement. Therefore check the changes out, confirm that they work for you, and use the +1 on the post to voice your opinion. |
| ) | ||
|
|
||
| # Add where_clause if specified | ||
| if pre_filter is not None and pre_filter.get("where_clause") is not None: | ||
| query += " {}".format(pre_filter["where_clause"]) | ||
|
|
||
| query += " ORDER BY VectorDistance(c.@embeddingKey, @embeddings)" | ||
| query += " ORDER BY VectorDistance(c[@embeddingKey], @embeddings)" |
There was a problem hiding this comment.
I'm not very familiar with Azure CDB NoSQL but is c.@embeddingKey equivalent to c[@embeddingKey]? Why make this change?
There was a problem hiding this comment.
As far as I know, the dot syntax is not supported for variable expressions. You are therefore forced to use brackets if you want to protect yourself against injections. CDB NoSQL seems quite restrictive in its capabilities here. But I do not have greater proficiency in it either, so there may be smarter ways about it.
dosubot
bot
added
the
lgtm
I will keep this PR as small as the changes made.
Description: fixes a fatal bug syntax error in AzureCosmosDBNoSqlVectorSearch
Issue: #27269 #25468