-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: Add Snowflake model session handling via keyfile and external sessions #27664
community: Add Snowflake model session handling via keyfile and external sessions #27664
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi, I added some more options to connect to the Snowflake models, but I can only integration test the variant of adding the Session directly and connecting via a keyfile. |
cc @sfc-gh-nmoiseyev - I think this should be done as part of the move of the snowflake chat models to the integration package https://github.com/langchain-ai/langchain-snowflake |
Hi, I hope the latest commit fixes the errors in the CI/CD pipeline. For the unittests I mock the package import now which is a bit ugly. Maybe someone has a better idea. For the integrationtests I removed the option to pass a Session to the model.
|
I think now all checks should succeed 🤞 |
- Implement session creation using keyfile for secure access without password - Keyfiles can be encrypted, with passwords stored in SNOWFLAKE_KEYFILE_PASSWORD - Add session as a parameter for external session management - Enables running langchain inside Snowflake with existing session handling - External sessions passed to the model are not closed on completion - Added comprehensive tests: - Session creation tests (keyfile, parameter-passed sessions) - Tests for varied environment variables and session configurations
…improved environment variable handling
- this removes the need to have the snowflake package installed - but this results in the issue of not testing passing a session
1882296
to
21f4286
Compare
Looks like I forgot to run make format again. Is there a possibility to have make format, make lint run before commit? |
believe some of the session mechanics were superceded by #27753 - if you want to reopen with just the changes related to aliasing feel free! |
Description
Implement session creation using keyfile for secure access without password
Add session as a parameter for external session management
Added comprehensive tests:
Updated the documentation at snowflake.ipynb