docs: Update Milvus documentation to correctly show how to filter in similarity_search #27723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter option for `similarity_search` and `similarity_search_with_score` seems to not have been implemented as presented in the documentation. Commit changes the `filter` option to use `expr` in documentation since this appears to have the intended behavior.
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
🤖:docs
ccurme
approved these changes
Oct 30, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description/Issue:
I had problems filtering when setting up a local Milvus db and noticed that the
filteroption in thesimilarity_searchandsimilarity_search_with_scoreappeared to do nothing. Instead, theexproption should be used.The
exproption is correctly used in the retriever example further down in the documentation.The
exproption seems to be correctly passed on, for example hereSolution:
Update the documentation for the functions mentioned to show intended behavior.