-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: use api token from Replicate constructor for service access #27859
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Fayvor Love <[email protected]>
Signed-off-by: Fayvor Love <[email protected]>
Signed-off-by: Fayvor Love <[email protected]>
Signed-off-by: Fayvor Love <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Signed-off-by: Fayvor Love <[email protected]>
Signed-off-by: Fayvor Love <[email protected]>
Signed-off-by: Fayvor Love <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why were the pytest options changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is unfortunately a breaking change for folks on the v0 replicate client. We have 2 options:
- we can close this PR and would recommend implementing a dedicated integration package, such that breaking changes can be tolerated moving forward. See these docs
- we can update the docs to show that this community Replicate integration is meant to be used with
replicate==0.x
- we can add some if/else statements to the integration to tolerate both the v0 and v1 sdk
let me know what you prefer! I'd be strongly in favor of [1]!
5.
let me know what you think! For [1] and [2], I think it makes sense to close this PR and reopen separately as a docs change. For [3] could iterate here. If you think [3] is the way forward and you have time to implement that compatibility before the holidays, let me know in the next day or two so we can keep this open! Otherwise we can close this and reopen when those changes have gone in. |
Hi! Thanks for the review. I won't have time to implement [1] but I will add some if/else switches for [3] this week, and you can make the call as to whether to merge. |
great let's go for [3] here this week! If you don't get to it that's ok - I'll close and you're welcome to reopen a pr when it's in! |
Description:
Issue:
#27861
Dependencies:
N/A
Twitter handle:
N/A