Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Feature/oxylabs components #27961

Closed

Conversation

Ulumanshu
Copy link

Package: Oxylabs Search Wrapper API

  • Description: This merge request introduces the implementation of the OxylabsSearchWrapperAPI
    along with the OxylabsSearchRun and OxylabsSearchResults tools within the LangChain package.
    These additions provide seamless integration with the Oxylabs API, enabling enhanced search capabilities.
  • Issue: N/A
  • Dependencies: To use this functionality, please ensure the Oxylabs SDK is installed:
pip install oxylabs

…nd image binary image content display option
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 1:58pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community labels Nov 7, 2024
@Ulumanshu
Copy link
Author

@baskaryan
Hello, could you please review the PR when you have a moment?

@Ulumanshu Ulumanshu changed the title Feature/oxylabs components Community: Feature/oxylabs components Nov 13, 2024
@Ulumanshu Ulumanshu changed the title Community: Feature/oxylabs components community: Feature/oxylabs components Nov 13, 2024
@Ulumanshu
Copy link
Author

@ccurme can you please take a look?

@efriis
Copy link
Member

efriis commented Nov 20, 2024

hey! would you be open to publishing your own package following this guide and just contributing docs?

@Ulumanshu
Copy link
Author

hey! would you be open to publishing your own package following this guide and just contributing docs?

Hi, thank you for your response. I am awaiting a decision from all the concerned parties and will get back to you as soon as I receive an answer. (reading the docs while waiting)

@Ulumanshu
Copy link
Author

hey! would you be open to publishing your own package following this guide and just contributing docs?

I am writing to follow up on your suggestion. We understand the proposal to publish this as a standalone package. However, the functionality aligns closely with LangChain's core objectives and could be highly beneficial to the broader community. We would prefer the Oxylabs integration to be included as part of the langchain community modules, with a commitment from our side to maintain it.

@Ulumanshu
Copy link
Author

@efriis Hi,
I’m following up on our PR to the langchain-community submitted on November 7. We’d like to check on its status and see if there’s anything we can do to assist the process.

@Ulumanshu
Copy link
Author

Hi @baskaryan, @efriis, @eyurtsev, @ccurme, @vbarda, @hwchase17,

I'm following up on the PR submitted to the LangChain community on November 7 regarding the Oxylabs components. We are eager to understand the status of the review and see if there's anything further we can do to assist the process. If there are any further steps we can take, please let us know.

Looking forward to your feedback. Thank you for your time!

Best regards,
Ulumanshu

@efriis
Copy link
Member

efriis commented Dec 16, 2024

hey there! sorry for the delay.

This adds a net-new community integration or feature, which has been replaced by dedicated integration packages. I'll close this PR, and would recommend reopening with just docs updates, as well as registering your package in libs/packages.yml! We'll be able to review simple PRs that only modify these two things much faster :)

Here's that guide linked again (it's been improved since I originally sent it), and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

To be clear, you would open a new PR with the exact same documentation added as this PR, so your integration will be just as discoverable (potentially more discoverable long-term) than a community integration!

@efriis efriis closed this Dec 16, 2024
@efriis
Copy link
Member

efriis commented Dec 16, 2024

The main reason for this switch to externally-maintained packages is the experience on this PR unfortuantely, where PRs adding and maintaining community integrations are some of the most time consuming for us to review, so the contributor experience is not good. Switching this paradigm to allow you to publish your own package and document it works better, as you don't have to wait ages for a review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants