Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: add new parameter default_headers #28700

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

lu-ohai
Copy link
Contributor

@lu-ohai lu-ohai commented Dec 13, 2024

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • "community: 1. add new parameter default_headers for oci model deployments and oci chat model deployments. 2. updated k parameter in OCIModelDeploymentLLM class."
  • PR message:

    • Description: 1. add new parameters default_headers for oci model deployments and oci chat model deployments. 2. updated k parameter in OCIModelDeploymentLLM class.
  • Add tests and docs:

    1. unit tests
    2. notebook

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:33pm

@dosubot dosubot bot added the community Related to langchain-community label Dec 13, 2024
@efriis efriis self-assigned this Dec 13, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question /suggestion to remove the route from headers. otherwise looks good.

Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml, deprecating this community integration in favor of your integration package}

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

There's some folks within oracle working on this that may be interested in collaborating

Dict: A dictionary containing the appropriate headers for the request.
"""
return {
"route": DEFAULT_INFERENCE_ENDPOINT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be included as a header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @efriis, thank you for your comment! In the current implementation of OCI Model Deployment, the route parameter needs to be passed through the header. For text and chat models, this parameter will be hardcoded by default. However, users can modify the value of the route parameter if needed by utilizing the default_header attribute.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@mrDzurb
Copy link
Contributor

mrDzurb commented Dec 18, 2024

one question /suggestion to remove the route from headers. otherwise looks good.

Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml, deprecating this community integration in favor of your integration package}

Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/

There's some folks within oracle working on this that may be interested in collaborating

Hi @efriis, moving to the integration package is already on our roadmap! Thanks!

@efriis efriis enabled auto-merge (squash) December 18, 2024 22:24
@efriis efriis merged commit 50afa7c into langchain-ai:master Dec 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants