-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add new parameter default_headers #28700
community: add new parameter default_headers #28700
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question /suggestion to remove the route from headers. otherwise looks good.
Also, if you're interested in maintaining this integration without us in the loop, we'd love to get an integration package out! Future PRs against langchain would just be {docs updates, as well as registering your package in libs/packages.yml
, deprecating this community integration in favor of your integration package}
Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/
There's some folks within oracle working on this that may be interested in collaborating
Dict: A dictionary containing the appropriate headers for the request. | ||
""" | ||
return { | ||
"route": DEFAULT_INFERENCE_ENDPOINT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be included as a header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @efriis, thank you for your comment! In the current implementation of OCI Model Deployment, the route
parameter needs to be passed through the header. For text and chat models, this parameter will be hardcoded by default. However, users can modify the value of the route
parameter if needed by utilizing the default_header
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
Hi @efriis, moving to the integration package is already on our roadmap! Thanks! |
Thank you for contributing to LangChain!
PR title: "package: description"
default_headers
for oci model deployments and oci chat model deployments. 2. updated k parameter in OCIModelDeploymentLLM class."PR message:
default_headers
for oci model deployments and oci chat model deployments. 2. updated k parameter in OCIModelDeploymentLLM class.Add tests and docs: