core[patch]: remove redundant imports #28861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove useless statements
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
WrRan
commented
Dec 21, 2024
| @@ -279,7 +279,7 @@ def _create_subset_model_v2( | |||
| fn_description: Optional[str] = None, | |||
| ) -> type[pydantic.BaseModel]: | |||
| """Create a pydantic model with a subset of the model fields.""" | |||
| from pydantic import ConfigDict, create_model | |||
There was a problem hiding this comment.
same issue. ConfigDict is imported at Line: 24
ccurme
approved these changes
Dec 23, 2024
| @@ -534,8 +534,6 @@ def get_config_jsonschema( | |||
|
|
|||
| def get_graph(self, config: Optional[RunnableConfig] = None) -> Graph: | |||
| """Return a graph representation of this Runnable.""" | |||
| from langchain_core.runnables.graph import Graph | |||
There was a problem hiding this comment.
Looks like the module-level import was originally just for type checking; that was later changed but this import was not removed 7d5800e
| @@ -279,7 +279,7 @@ def _create_subset_model_v2( | |||
| fn_description: Optional[str] = None, | |||
| ) -> type[pydantic.BaseModel]: | |||
| """Create a pydantic model with a subset of the model fields.""" | |||
| from pydantic import ConfigDict, create_model | |||
dosubot
bot
added
the
lgtm
ccurme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graphhas been imported at Line: 62