Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeshift - Langchain integration of pipeshift #29114

Merged
merged 23 commits into from
Jan 22, 2025

Conversation

sohanpsai
Copy link
Contributor

Description: Added pipeshift integration. This integrates pipeshift LLM and ChatModels APIs with langchain
Dependencies: none

Unit Tests & Integration tests are added

Documentation is added as well

This PR is w.r.t #27390 and as per request, a freshly minted langchain-pipeshift package is uploaded to PYPI. Only changes to the docs & packages.yml are made in langchain master branch

@sohanpsai sohanpsai requested a review from efriis as a code owner January 9, 2025 15:50
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 9, 2025
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 3:03am

@dosubot dosubot bot added community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 9, 2025
@@ -333,3 +333,7 @@ packages:
path: .
repo: DS4SD/docling-langchain
downloads: 0
- name: langchain-pipeshift
path: .
repo:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll have to fill this out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

@efriis efriis self-assigned this Jan 10, 2025
"source": [
"# ChatPipeshift\n",
"\n",
"This will help you getting started with Pipeshift [chat models](/docs/concepts/chat_models/). For detailed documentation of all ChatPipeshift features and configurations head to the [API reference](https://python.langchain.com/api_reference/pipeshift/chat_models/langchain_pipeshift.chat_models.ChatPipeshift.html).\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API ref link 404s. LangChain doesn't build API refs for external packages, so this should be updated or removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright updated ref links

don't I need to add and update Chat models and LLMs entry in featureTable.js ?

"| [ChatPipeshift](https://python.langchain.com/api_reference/pipeshift/chat_models/langchain_pipeshift.chat_models.ChatPipeshift.html) | [langchain-pipeshift](https://python.langchain.com/api_reference/pipeshift/index.html) | ✅ | beta| ❌ | ![PyPI - Downloads](https://img.shields.io/pypi/dm/langchain-pipeshift?style=flat-square&label=%20) | ![PyPI - Version](https://img.shields.io/pypi/v/langchain-pipeshift?style=flat-square&label=%20) |\n",
"\n",
"### Model features\n",
"| [Tool calling](/docs/how_to/tool_calling) | [Structured output](/docs/how_to/structured_output/) | JSON mode | [Image input](/docs/how_to/multimodal_inputs/) | Audio input | Video input | [Token-level streaming](/docs/how_to/chat_streaming/) | Native async | [Token usage](/docs/how_to/chat_token_usage_tracking/) | [Logprobs](/docs/how_to/logprobs/) |\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically structured output refers to the ability to use chat_model.with_structured_output, which by default will use tool calling. Since tool calling is not supported by ChatPipeshift, in what sense does it support structured output?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops my bad, pipeshift in the process of providing tool calling support. Mistakenly added support for structured_output

@efriis efriis enabled auto-merge (squash) January 22, 2025 02:53
@efriis efriis merged commit de1fc48 into langchain-ai:master Jan 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants