Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Add goodfire chat model #29427

Closed

Conversation

keenanpepper
Copy link
Contributor

  • Description: Add a chat model implementation for Goodfire
  • Issue: n/a
  • Dependencies: goodfire package as an optional dependency
  • Twitter handle: keenanpepper

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 26, 2025
Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 26, 2025 2:06am

@dosubot dosubot bot added the community Related to langchain-community label Jan 26, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for this!

This adds a new integration into langchain-community. We are recommending that these be implemented via external packages. Would you be interested in publishing an OSS integration package (e.g., langchain-goodfire)? We've written a walkthrough on this process here:

https://python.langchain.com/docs/contributing/how_to/integrations/

We are encouraging contributors of LangChain integrations to go this route. This way we don't have to be in the loop for reviews, you're able to properly integration test the model, and you have control over versioning (including of the goodfire dependency).

Docs would continue to be maintained in the langchain repo.

Let me know what you think!

@ccurme ccurme closed this Jan 27, 2025
@keenanpepper
Copy link
Contributor Author

Ah, thanks @ccurme I didn't know what the preferred structure was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants